feat: 알림 눌렀을 때 인증샷 빈화면 버그 수정#355
Merged
Merged
Conversation
Member
|
@coderabbitai summary |
clxxrlove
reviewed
Jun 10, 2026
Comment on lines
+187
to
+195
| case let .navigateToGoalDetail(id, owner, date): | ||
| state.routes.append(.detail) | ||
| let shouldFetchGoalDetail = state.goalDetail != nil | ||
| state.goalDetail = .init( | ||
| currentUser: owner, | ||
| id: id, | ||
| verificationDate: date | ||
| ) | ||
| return .none | ||
| return shouldFetchGoalDetail ? .send(.goalDetail(.view(.onAppear))) : .none |
Member
There was a problem hiding this comment.
이미 인증샷 상세 화면에 있는 상태에서 알림을 누르면, route가 중첩될수도 있을 거 같은데
case let .navigateToGoalDetail(id, owner, date):
let isAlreadyOnDetail = state.routes.last == .detail
if !isAlreadyOnDetail {
state.routes.append(.detail)
}
state.goalDetail = .init(
currentUser: owner,
id: id,
verificationDate: date
)
return isAlreadyOnDetail
? .send(.goalDetail(.view(.onAppear)))
: .none이렇게 교체하는 건 어때 ?
Contributor
Author
There was a problem hiding this comment.
이런식으로 하려했는데 알림 누를 때 mainTab에서 route를 다 비워 두길래 굳이 안하긴했는데
case let .notificationDeepLinkReceived(deepLink):
state.selectedTab = .home
state.home.routes = []근데 안정성 생각했을 때 있는게 좋긴 할 거 같아서 반영할게!
jihun32
force-pushed
the
fix/#352/TWI-130
branch
from
c6fdb4a to
8478756
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 관련 이슈
📙 작업 내역
🎨 스크린샷 또는 시연 영상 (선택)
Simulator.Screen.Recording.-.iPhone.17.Pro.26.-.2026-06-08.at.23.10.12.mov